From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used ...................................................................... Patch Set 4: Code-Review+1 (2 comments) waiting for Petr and reply about functional test. https://gerrit.ovirt.org/#/c/80505/4//COMMIT_MSG Commit Message: Line 8: Line 9: In a setup with a bridgeless network that has bond, vlan and DHCP, the Line 10: ifup action is performed in a nonblocking manner and may cause a race Line 11: where the vlan link is assumed to exist but the ifup has not yet Line 12: executed. why won't we add a functional test for this case? this should happen in a follow-up patch, since we need this backported fast. Line 13: Line 14: This patch introduces a wait-for-link mechanism for this specific scenario. Line 15: Line 16: Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587 Line 10: ifup action is performed in a nonblocking manner and may cause a race Line 11: where the vlan link is assumed to exist but the ifup has not yet Line 12: executed. Line 13: Line 14: This patch introduces a wait-for-link mechanism for this specific scenario. having a paragraph like this is usually a hist that that the patch should have been broken in two. Line 15: Line 16: Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587 Line 17: Bug-Url: https://bugzilla.redhat.com/1479829 -- To view, visit https://gerrit.ovirt.org/80505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
