From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: net: Wait for vlan link creation when bond-vlan-dhcp is used ...................................................................... Patch Set 4: which process would you like to wait for? the vdsm-requested ifup? the dhclient run by it? how long would you wait for it? When testing asynchronous code, your test has to have a timeout. If Vdsm does not set a dhcp address within 60 seconds when the dhcp server is sitting on the same host, we can declare that this is a failure. -- To view, visit https://gerrit.ovirt.org/80505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b638ec5b3fe974be04d3e62437553262978f587 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman <mbur...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
