From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: checkimages hook: avoid using execCmd(sync=False) ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/80212/2/vdsm_hooks/checkimages/before_vm_start.py File vdsm_hooks/checkimages/before_vm_start.py: Line 91: sys.stderr.write('checkimages: %s image check operation timed out.' % Line 92: path) Line 93: sys.stderr.write('Increate timeout or check image availability.') Line 94: sys.exit(2) Line 95: elif rc == 0: > I would add the error case after the expected value. I wanted to rattle as little code as I can, it's not like I enjoy touching this most-probably dead hook. Line 96: sys.stderr.write('checkimages: %s image check returned: %s\n' % Line 97: (path, out)) Line 98: else: Line 99: sys.stderr.write('checkimages: Error running %s command: %s\n' % -- To view, visit https://gerrit.ovirt.org/80212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec70891901a0473f5a863ca8ffd0c1df8046962 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
