From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80212 )
Change subject: checkimages hook: avoid using execCmd(sync=False) ...................................................................... checkimages hook: avoid using execCmd(sync=False) I would like to move hooking.py to the common package. However, common does not have the complex execCmd, and is not likely to ever have something with sync=False. This patch reimplements exec-with-timeout using threading.Timer instead of sync=False. Change-Id: I2ec70891901a0473f5a863ca8ffd0c1df8046962 Signed-off-by: Dan Kenigsberg <[email protected]> --- M vdsm_hooks/checkimages/before_vm_start.py 1 file changed, 14 insertions(+), 9 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/80212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ec70891901a0473f5a863ca8ffd0c1df8046962 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
