Dan Kenigsberg has posted comments on this change.
Change subject: Add default MTU=1500 to NIC's ifcfg files.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 514: self._backup(cf)
Line 515: try:
Line 516: hwlines = [line for line in open(cf).readlines()
Line 517: if line.startswith('HWADDR=')]
Line 518: l = ['DEVICE=%s\n' % nic, 'ONBOOT=yes\n', 'MTU=1500\n'] +
hwlines
I do not think this change is consistent enough. Let us assume that there is a
nic with a Linux-level default mtu of 2000.
When creating a network on top of this nic, we'd be using mtu=2000. After
deleting this network, and creating it again, we'd be using mtu=1500 according
to your setting here.
We should better have a vdsm-wide default MTU for cases where MTU is not
supplied by Engine. It should replace "None" in
- mtu = confParams.get('MTU', None)
+ mtu = confParams.get('MTU', str(DEFAULT_MTU))
Line 519: open(cf, 'w').writelines(l)
Line 520: except IOError:
Line 521: pass
Line 522:
--
To view, visit http://gerrit.ovirt.org/9547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvov...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Meni Yakove <myak...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
