Dan Kenigsberg has posted comments on this change. Change subject: Add default MTU=1500 to NIC's ifcfg files. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/configNetwork.py Line 514: self._backup(cf) Line 515: try: Line 516: hwlines = [line for line in open(cf).readlines() Line 517: if line.startswith('HWADDR=')] Line 518: l = ['DEVICE=%s\n' % nic, 'ONBOOT=yes\n', 'MTU=1500\n'] + hwlines oh, after re-adding the network, the MTU=2000 would be removed, so my scenario does not lead to a problem. I still think that having a clear vdsm-wide default is a bit nicer, but is not required to solve any bug (actually, and ovirt-wide default is even better). Line 519: open(cf, 'w').writelines(l) Line 520: except IOError: Line 521: pass Line 522: -- To view, visit http://gerrit.ovirt.org/9547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0553a3956ea06586e0ece758932f00a9af640611 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Meni Yakove <myak...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches