Laszlo Hornyak has posted comments on this change.

Change subject: cpu mode support for vdsm
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 721:         model = features[0]
Line 722:         cpu = self.doc.createElement('cpu')
Line 723:         cpu.setAttribute('match', 'exact')
Line 724: 
Line 725:         #and now for something completely different
It makes people want to know.
Line 726:         if model == 'hostPassthrough':
Line 727:             cpu.setAttribute('mode', 'host-passthrough')
Line 728:         elif model == 'hostModel':
Line 729:             cpu.setAttribute('mode', 'host-model')


Line 725:         #and now for something completely different
Line 726:         if model == 'hostPassthrough':
Line 727:             cpu.setAttribute('mode', 'host-passthrough')
Line 728:         elif model == 'hostModel':
Line 729:             cpu.setAttribute('mode', 'host-model')
Done
Line 730:         else:
Line 731:             m = self.doc.createElement('model')
Line 732:             m.appendChild(self.doc.createTextNode(model))
Line 733:             cpu.appendChild(m)


--
To view, visit http://gerrit.ovirt.org/9507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54fb440ef52255f0a7933b000b9b599c2d056021
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to