Antoni Segura Puimedon has posted comments on this change. Change subject: [WIP] netwiring: [4/4] Add API definitions. ......................................................................
Patch Set 27: (1 inline comment) .................................................... File vdsm/vdsmd.init.in Line 479: log_failure_msg "$prog: Failed to define network filters on libvirt" Line 480: return $ret_val Line 481: fi Line 482: Line 483: python @VDSMDIR@/dummybr.pyc Now that we do not redirect stdout and stderr, we have a very ugly behavior when the bridge already existed. Since we changed our dummybr.py to ask for forgiveness, when it raises the exception, it also writes to stderr... Line 484: ret_val=$? Line 485: if [ $ret_val -ne 0 ] Line 486: then Line 487: log_failure_msg "$prog: Failed to create ephemeral dummy bridge." -- To view, visit http://gerrit.ovirt.org/9562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b9b4f49f80466a83e3e13f1042ac2a8866c6bcd Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
