Antoni Segura Puimedon has posted comments on this change.
Change subject: netwiring: [4/4] Add API definitions.
......................................................................
Patch Set 29: (1 inline comment)
....................................................
File vdsm/dummybr.py
Line 45: if not os.path.exists('/sys/class/net/%s' % DUMMY_BRIDGE):
Line 46: createEphemeralBridge(DUMMY_BRIDGE)
Line 47: addBridgeToLibvirt(DUMMY_BRIDGE)
Line 48: except libvirtError as le:
Line 49: if 'already exists' not in le.message:
The information I can get from the exception is (with what corresponds in
virterror.h:
(9,
19,
"operation failed: network 'foo' already exists with uuid
52388a7b-ae30-b940-c307-219dd66af360",
2,
'operation failed: %s',
"network 'foo' already exists with uuid 52388a7b-ae30-b940-c307-219dd66af360",
None,
-1,
-1)
That translates to:
VIR_ERR_OPERATION_FAILED = 9 /* a command to the hypervisor failed */
VIR_FROM_NETWORK = 19, /* Error from network config */
VIR_ERR_ERROR = 2 /* An error */
So I think I would prefer to recover the ask for permission implementation.
Line 50: sys.stderr.write(le.message)
Line 51: sys.exit(1)
Line 52: except Exception as e:
Line 53: sys.stderr.write(e.message)
--
To view, visit http://gerrit.ovirt.org/9562
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9b4f49f80466a83e3e13f1042ac2a8866c6bcd
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
