Ayal Baron has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/fileSD.py
Line 153: except OSError as e:
Line 154: if e.errno == errno.EINVAL:
Line 155: self.log.error("Underlying file system doesn't
support"
Line 156: "direct IO")
Line 157: raise se.StorageDomainCreationError()
Please raise a specific error that can be localized etc.
Line 158:
Line 159: raise
Line 160: finally:
Line 161: oop.getProcessPool(self.sdUUID).os.unlink(testFilePath)
--
To view, visit http://gerrit.ovirt.org/9749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
