Federico Simoncelli has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it ......................................................................
Patch Set 5: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2012-12-05 11:11:22 -0500 Line 4: Commit: Saggi Mizrahi <[email protected]> Line 5: CommitDate: 2013-01-07 11:57:21 -0500 Line 6: Line 7: Check that underlying filesystem supports direct IO before creating a domain on it This doesn't follow the commit template. relevant-area: short subject under ~50 characters Line 8: Line 9: This is done so that we don't allow posixfs domains on top of targets Line 10: that don't support direct IO. Line 11: .................................................... File vdsm/storage/fileSD.py Line 133: self.remotePath = os.path.basename(self.mountpoint) Line 134: self.metafile = os.path.join(domainPath, sd.DOMAIN_META_DATA, Line 135: sd.METADATA) Line 136: Line 137: self.validateFileSystemFeatures() I'm not sure if we really want to implicitly to a directio test every time we instantiate a FileStorageDomain object. Moreover consider that this would run on all the host (SPM/HSMs). I agree that we might want this check, but probably not here. Line 138: Line 139: metadata = FileSDMetadata(self.metafile) Line 140: sdUUID = metadata[sd.DMDK_SDUUID] Line 141: domaindir = os.path.join(self.mountpoint, sdUUID) -- To view, visit http://gerrit.ovirt.org/9749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf14d1c4737a88e693e5bebb896aef382b8b424c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: humble devassy <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
