Dan Kenigsberg has posted comments on this change. Change subject: netwiring: [4/4] Add API definitions. ......................................................................
Patch Set 32: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 984: for attr, value in kwargs.iteritems(): Line 985: if attr == 'nicModel' and value == 'pv': Line 986: kwargs[attr] = 'virtio' Line 987: elif attr == 'network' and value == '': Line 988: kwargs[attr] = DUMMY_BRIDGE I'd rather have a cleaner if self.network = '': self.network = DUMMY_BRIDGE Line 989: LibvirtVmDevice.__init__(self, conf, log, **kwargs) Line 990: self.sndbufParam = False Line 991: self._customize() Line 992: -- To view, visit http://gerrit.ovirt.org/9562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b9b4f49f80466a83e3e13f1042ac2a8866c6bcd Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
