Alona Kaplan has posted comments on this change. Change subject: netwiring: [4/4] Add API definitions. ......................................................................
Patch Set 32: I would prefer that you didn't submit this annoying text on restart libvir: Network Driver error : operation failed: network ';vdsmdummy;' already exists with uuid 3267c6e2-03c8-81e7-01e5-336eaa65547c /usr/share/vdsm/dummybr.py:49: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6 if 'already exists' not in le.message: also, need to convert linkstate to boolean in libvirtvm.py line 1023 utils.tobool(self.linkActive) thanks, danken. -- To view, visit http://gerrit.ovirt.org/9562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b9b4f49f80466a83e3e13f1042ac2a8866c6bcd Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
