Dan Kenigsberg has posted comments on this change. Change subject: Allow to remove NIC if it not in use ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/configNetwork.py Line 1142: cf = configWriter.NET_CONF_PREF + nic Line 1143: configWriter._updateConfigValue(cf, 'MTU', DEFAULT_MTU, False) Line 1144: ifup(nic) Line 1145: Line 1146: ifup(bonding) I'm pretty sure you have to take the bond up first, and only then sort the nics and take them up one by one. Just like we do in addNetwork() Line 1147: Line 1148: Line 1149: def clientSeen(timeout): Line 1150: start = time.time() -- To view, visit http://gerrit.ovirt.org/9508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8e5fce14fc38c3df9c0b12dc4077726436807e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
