Dan Kenigsberg has posted comments on this change. Change subject: Allow to remove NIC if it not in use ......................................................................
Patch Set 7: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 1103: Line 1104: nic = nics[0] if nics else None Line 1105: iface = bonding if bonding else nic Line 1106: if iface: Line 1107: ifdown(iface) is it really ok to ifdown the nic before doing it to the vlan device? Or are we adding something like the bond-related ignored error? Line 1108: if vlan: Line 1109: configWriter.removeVlan(vlan, iface) Line 1110: else: Line 1111: cf = configWriter.NET_CONF_PREF + iface -- To view, visit http://gerrit.ovirt.org/9508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8e5fce14fc38c3df9c0b12dc4077726436807e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
