Igor Lvovsky has posted comments on this change. Change subject: Allow to remove NIC if it not in use ......................................................................
Patch Set 7: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 1103: Line 1104: nic = nics[0] if nics else None Line 1105: iface = bonding if bonding else nic Line 1106: if iface: Line 1107: ifdown(iface) No, we not needed to add anything. It's totaly fine to ifdown NIC/Bond before removing vlan device. If we already speaking about this, the thing that we can to do it remove ifdown(vlanDev) before we remove it in removeVlan(). It not must but it better (in different patch of course), because if we ifdown(vlanDev) before we remove it, we get the error from 'ip link del vlanDev': MainProcess|Thread-37::DEBUG::2012-12-12 12:29:50,580::misc::84::Storage.Misc.excCmd::(<lambda>) '/sbin/ifdown bond0.300' (cwd None) MainProcess|Thread-37::DEBUG::2012-12-12 12:29:50,685::misc::84::Storage.Misc.excCmd::(<lambda>) SUCCESS: <err> = 'bridge test-network3 does not exist!\n'; <rc> = 0 MainProcess|Thread-37::DEBUG::2012-12-12 12:29:50,685::misc::84::Storage.Misc.excCmd::(<lambda>) '/sbin/ip link del bond0.300' (cwd None) MainProcess|Thread-37::DEBUG::2012-12-12 12:29:50,693::misc::84::Storage.Misc.excCmd::(<lambda>) FAILED: <err> = 'Cannot find device "bond0.300"\n'; <rc> = 255 Line 1108: if vlan: Line 1109: configWriter.removeVlan(vlan, iface) Line 1110: else: Line 1111: cf = configWriter.NET_CONF_PREF + iface -- To view, visit http://gerrit.ovirt.org/9508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8e5fce14fc38c3df9c0b12dc4077726436807e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
