Dan Kenigsberg has posted comments on this change.
Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
could you ask Meni to verify that this (after dropping nicSort) has no
regressions? it sounds too good to be true..
....................................................
File vdsm/configNetwork.py
Line 1003:
Line 1004: # Now we can run ifup for all interfaces
Line 1005: if bonding:
Line 1006: ifup(bonding, bondBootproto == 'dhcp' and not blockingDhcp)
Line 1007: else:
if not bonding:
there is only one nic, so there is no point in nicSort'ing.
Line 1008: # NICs must be activated in the same order of boot time
Line 1009: # to expose the correct MAC address.
Line 1010: for nic in nicSort(nics):
Line 1011: ifup(nic, options.get('bootproto') == 'dhcp' and not
blockingDhcp)
--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
