Antoni Segura Puimedon has posted comments on this change.
Change subject: Remove redundant ifupping of bonded ifaces.
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm/configNetwork.py
Line 1005: if bonding:
Line 1006: ifup(bonding, bondBootproto == 'dhcp' and not blockingDhcp)
Line 1007: else:
Line 1008: # NICs must be activated in the same order of boot time
Line 1009: # to expose the correct MAC address.
I was thinking about checking if zero or one, but since it is either a list of
zero or one elements I liked more the for.
The comment I agree that should be removed.
Line 1010: for nic in nics:
Line 1011: ifup(nic, options.get('bootproto') == 'dhcp' and not
blockingDhcp)
Line 1012:
Line 1013: # Now we can ifup VLAN interface, because bond and nic already up
Line 1006
Line 1007
Line 1008
Line 1009
Line 1010
I'll review that. it is quite possible that it can be dropped. I saw it being
used by your more delicate rollback.
--
To view, visit http://gerrit.ovirt.org/10009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I069ac2b60a2d591b5cc76484e0d7eee30b1429e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Meni Yakove <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
