Eduardo has posted comments on this change.

Change subject: Take care of 'No devices found' when calling dmsetup status
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/devicemapper.py
Line 178:     for statusLine in out:
Line 179:         try:
Line 180:             devName, statusLine = statusLine.split(":", 1)
Line 181:         except ValueError:
Line 182:             if len(out) == 1:
Add a comment "No devices found" here please.
Line 183:                 return res
Line 184:             else:
Line 185:                 raise
Line 186: 


--
To view, visit http://gerrit.ovirt.org/10035
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb487feab43741267e4f7027c1baf033148683c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to