Yeela Kaplan has posted comments on this change.
Change subject: Take care of 'No devices found' when calling dmsetup status
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/devicemapper.py
Line 184: return an empty list when status output is: No
devices found
Line 185: """
Line 186: return res
Line 187: else:
Line 188: raise
This is a different case.
When the rc!=0 'dmsetup status' failed, not vdsm.
When there's a ValueError we want to see in the log exactly what happened in
the parsing of the output and what caused vdsm to fail, we don't want a general
exception.
and generally: we did get the device statuses, we just weren't able to parse
them.
Line 189:
Line 190: for m in PATH_STATUS_RE.finditer(statusLine):
Line 191: devNum, status = m.groups()
Line 192: physdevName = findDev(*[int(i) for i in
devNum.split(":")])
--
To view, visit http://gerrit.ovirt.org/10035
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb487feab43741267e4f7027c1baf033148683c1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
