Antoni Segura Puimedon has posted comments on this change. Change subject: Yet another bunch of completely pep8 fixed files. ......................................................................
Patch Set 2: (1 inline comment) .................................................... File Makefile.am Line 51: vds_bootstrap/miniyum.py \ Line 52: vdsm-tool \ Line 53: vdsm/*.py \ Line 54: vdsm/*.py.in \ Line 55: vdsm/sos/vdsm.py.in \ The explanation is in one of my reviews. Basically that pep8 1.3.3 does not allow you to blacklist relative paths because it truncates the path to the basename. E.g. blacklisting vdsm/sos/vdsm.py is only possible adding vdsm.py to the blacklist which is far too general for my taste. Line 56: vdsm/storage/__init__.py \ Line 57: vdsm/storage/blockVolume.py \ Line 58: vdsm/storage/devicemapper.py \ Line 59: vdsm/storage/domainMonitor.py \ -- To view, visit http://gerrit.ovirt.org/10041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d0e38fd43bd76febf3bfb231c4257298e6d921f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
