Dan Kenigsberg has posted comments on this change. Change subject: Don't fail silently when ifup fails. ......................................................................
Patch Set 12: I would prefer that you didn't submit this (1 inline comment) .................................................... File tests/configNetworkTests.py Line 354: with MonkeyPatchScope([ Line 355: (netinfo, 'NET_CONF_BACK_DIR', Line 356: os.path.join(self._tempdir, 'netback')), Line 357: (netinfo, 'NET_CONF_DIR', self._tempdir), Line 358: (configNetwork.ConfigWriter, '_stopAtomicDevices', lambda x: 0), I suppose this is because my "delicate network rollback" is not delicate enough - _stopAtomicDevices should not ifdown bond elements or nics with vlan. Let's improve _sortModifiedIfcfgs() instead of skipping it. Line 359: (configNetwork.ConfigWriter, '_startAtomicDevices', lambda x: 0), Line 360: ]): Line 361: #after vdsm package is installed, the 'vdsm' account will be Line 362: #created if no 'vdsm' account, we should skip this test -- To view, visit http://gerrit.ovirt.org/8415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
