Igor Lvovsky has posted comments on this change.
Change subject: Don't fail silently when ifup fails.
......................................................................
Patch Set 10: I would prefer that you didn't submit this
Dan, Toni
patch is good, but we can't take it because it raise the old bond issue [1] and
will fail the ruth tests
[1] Bond's MAC addresses order:
Traceback (most recent call last):
File "/usr/share/vdsm/supervdsmServer.py", line 77, in wrapper
return func(*args, **kwargs)
File "/usr/share/vdsm/supervdsmServer.py", line 163, in setupNetworks
return configNetwork.setupNetworks(networks, bondings, **options)
File "/usr/share/vdsm/configNetwork.py", line 1344, in setupNetworks
_editBondings(bondings, configWriter)
File "/usr/share/vdsm/configNetwork.py", line 1244, in _editBondings
ifup(nic)
File "/usr/share/vdsm/configNetwork.py", line 82, in ifup
rc, out, err = _ifup(iface)
File "/usr/share/vdsm/configNetwork.py", line 71, in _ifup
raise ConfigNetworkError(ne.ERR_FAILED_IFUP, out[-1])
ConfigNetworkError: (29, 'Device eth3 has different MAC address than expected,
ignoring.')
--
To view, visit http://gerrit.ovirt.org/8415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
