Ayal Baron has posted comments on this change. Change subject: [WIP] BZ#748386 - Refactor and move volume.qemuConvert into qemuImg. ......................................................................
Patch Set 6: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/qemuImg.py Line 110: and dstFmt == volume.COW_FORMAT): Line 111: Line 112: # TODO - confirm backing_file format in use already Line 113: # Is it the full path or img/vol? Line 114: cmd += ["-o","backing_file="+src.getParentVolume().getVolumePath() + \ src looks wrong here. iiuc this will create a tree instead of 2 separate chains. you should check to see if the destination volume has a backing file and only in that case pass the backing_file. Don't forget that this method is used to collapse images and always using a backing file breaks that functionality. Line 115: ",backing_fmt="+volume.fmt2str(src.getParentVolume().getFormat())] Line 116: Line 117: cmd += [src.getVolumePath(), dst.getVolumePath()] Line 118: -- To view, visit http://gerrit.ovirt.org/8728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7adc41e8a9f5d4b9faa58a8cf5bec685b66e303e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Lee Yarwood <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
