Ayal Baron has posted comments on this change. Change subject: [WIP] BZ#748386 - Refactor and move volume.qemuConvert into qemuImg. ......................................................................
Patch Set 6: (1 inline comment) .................................................... File vdsm/qemuImg.py Line 111: Line 112: # TODO - confirm backing_file format in use already Line 113: # Is it the full path or img/vol? Line 114: cmd += ["-o","backing_file="+src.getParentVolume().getVolumePath() + \ Line 115: ",backing_fmt="+volume.fmt2str(src.getParentVolume().getFormat())] note that I'm not sure how this would work at all. Perhaps you do need to use the source and after qemu-img finishes rebase unsafe on the destination parent. In any event, this seems like a dangerous change that needs a lot of testing. I would actually opt for an initial solution replacing ddWatchCopy in interImagesCopy with cp (like you already did but abandoned) and after that is in (to at least have sparse copy) then start moving to a qemu-img based solution. Line 116: Line 117: cmd += [src.getVolumePath(), dst.getVolumePath()] Line 118: Line 119: rc, out, err = execCmd(cmd) -- To view, visit http://gerrit.ovirt.org/8728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7adc41e8a9f5d4b9faa58a8cf5bec685b66e303e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Lee Yarwood <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
