Dan Kenigsberg has posted comments on this change. Change subject: Fix configNetworkTests.ConfigWriter monkeypatch. ......................................................................
Patch Set 1: I would prefer that you didn't submit this Could you tell why we have NET_CONF_PREF defined twice? Once in netinfo.NET_CONF_PREF, and another in configNetwork.ConfigWriter.NET_CONF_PREF ? A proper monkeypatch should change both; a proper code should have only one. Also, please say in the commit message, why current monkey patching is insufficient. -- To view, visit http://gerrit.ovirt.org/10161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6925c59650aaa81fa925a4be3bcd72dcbebbb415 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
