Dan Kenigsberg has submitted this change and it was merged. Change subject: drop configNetworkTests.ConfigWriter.NET_CONF_PREF dup ......................................................................
drop configNetworkTests.ConfigWriter.NET_CONF_PREF dup NET_CONF_PREF should be defined only once, in netinfo.py. Since the tests are using a non-real location for ifcfg files, that single definiion should be monkey-patched, or we would stumble upon null-named devices. Change-Id: I6925c59650aaa81fa925a4be3bcd72dcbebbb415 Signed-off-by: Antoni S. Puimedon <[email protected]> --- M tests/configNetworkTests.py M vdsm/configNetwork.py 2 files changed, 18 insertions(+), 17 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6925c59650aaa81fa925a4be3bcd72dcbebbb415 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
