Dan Kenigsberg has posted comments on this change.
Change subject: Add a flag to libvirtvm's status to report watchdog event
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
I'd appreciate Adam's opinion on this schema change.
....................................................
File vdsm/libvirtvm.py
Line 2225: except IndexError:
Line 2226: return "Received unknown watchdog action(%s)" %
action
Line 2227:
Line 2228: self._watchdogEvent["time"] = time.time()
Line 2229: self._watchdogEvent["action"] = actionToString(action)
I think that it would be nicer if the API is more machine-friendly. Having long
English string with spaces is good for humans (living in Europe...), but
shorter constants such as ForcedPowerOff, CPUsPause, etc are easier to parse,
and to define in the schema.
Line 2230: self.log.info("Watchdog event comes from guest %s. "
Line 2231: "Action: %s", self.conf['vmName'],
Line 2232: actionToString(action))
Line 2233:
--
To view, visit http://gerrit.ovirt.org/9429
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa676299c748d761e216469569156140a79af65
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
