Adam Litke has posted comments on this change.
Change subject: Add a flag to libvirtvm's status to report watchdog event
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm_api/vdsmapi-schema.json
Line 4789: #
Line 4790: # @RequestShutdown: Guest is requested to gracefully shutdown
Line 4791: #
Line 4792: # @DebugLogged: No action, a debug message logged
Line 4793: #
Can you try to stick with single (all lowercase) words for these? It is an
'enum' so the strings just become the names of integer constants.
how about: ['ignore', 'pause', 'reset', 'destroy', 'shutdown', 'log']
Line 4794: # Since: 4.10.1
Line 4795: ##
Line 4796: {'enum': 'WatchdogEventAction',
Line 4797: 'data': ['NoAction', 'CPUsPause', 'CPUsReset', 'ForcedPowerOff',
Line 4875: # @netIfaces: Network device address info as reported by
the agent
Line 4876: #
Line 4877: # @watchdogEvent: #optional The message of watchdog event when
it was
Line 4878: # triggered
Line 4879: #
According to the type, this really isn't a message.
"Information about the most recent watchdog event". Would be more appropriate
I think.
Line 4880: # Since: 4.10.0
Line 4881: ##
Line 4882: {'type': 'RunningVmStats',
Line 4883: 'data': {'displayPort': 'uint', 'displaySecurePort': 'uint',
Line 4894: 'appsList': ['str'], 'guestIPs': 'str',
Line 4895: 'memoryStats': 'GuestMemoryStats', 'balloonInfo':
'BalloonInfo',
Line 4896: 'disksUsage': ['GuestMountInfo'],
Line 4897: 'netIfaces': ['GuestNetworkDeviceInfo'],
Line 4898: 'watchdogEvent': 'WatchdogEvent'}}
It's optional, right? Should be: '*watchdogEvent'
Line 4899:
Line 4900: ##
Line 4901: # @VmStats:
Line 4902: #
--
To view, visit http://gerrit.ovirt.org/9429
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa676299c748d761e216469569156140a79af65
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
