Saggi Mizrahi has posted comments on this change. Change subject: Adding getBiosInfo API to vdsm cli and merge bios information with vdsGetCaps ......................................................................
Patch Set 12: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/dmidecodeUtil.py Line 23: Line 24: Line 25: def __leafDict(d, n): Line 26: for k in d: Line 27: if type(d[k]) == dict: It should actually be isinstance(d[k], dict) Line 28: __leafDict(d[k], n) Line 29: else: Line 30: n[k] = d[k] Line 31: -- To view, visit http://gerrit.ovirt.org/9258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Andrew Cathrow <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
