Alon Bar-Lev has posted comments on this change.
Change subject: Adding getBiosInfo API to vdsm cli and merge bios information
with vdsGetCaps
......................................................................
Patch Set 16: (2 inline comments)
....................................................
File vdsm/supervdsmServer.py
Line 38: _glusterEnabled = False
Line 39: from parted_utils import getDevicePartedInfo as _getDevicePartedInfo
Line 40: from md_utils import getMdDeviceUuidMap as _getMdDeviceUuidMap
Line 41:
Line 42: from platform import machine
I think dan likes this to be together with all standard python modules. Not
sure the importance of importing machine explicitly.
Line 43: from lsblk import getLsBlk as _getLsBlk
Line 44: from storage.multipath import getScsiSerial as _getScsiSerial
Line 45: from storage.iscsi import forceIScsiScan as _forceIScsiScan
Line 46: from storage.iscsi import getDevIscsiInfo as _getdeviSCSIinfo
Line 95: # This method exists for testing purposes
Line 96: return True
Line 97:
Line 98: @logDecorator
Line 99: def getDmidecodeInfo(self, *args, **kwargs):
probably have to rename if ppc will provide something else from dmi...
Maybe getHardwareInfo()? this apply to the entire patchset, no?
Line 100: if machine() in ('x86_64', 'i686'):
Line 101: from dmidecodeUtil import getSystemStructure as
_getSystemStructure
Line 102: return _getSystemStructure()
Line 103: else:
--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Andrew Cathrow <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
