Dan Kenigsberg has posted comments on this change. Change subject: Don't fail silently when ifup fails. ......................................................................
Patch Set 16: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/configNetwork.py Line 355: for dev in reversed(self._sortModifiedIfcfgs()): Line 356: ifdown(dev) Line 357: Line 358: def _startAtomicDevices(self): Line 359: for dev in self._sortModifiedIfcfgs(): we need to catch the new exception here, to keep our "best effort" semantics for the rollback operation. Line 360: ifup(dev) Line 361: Line 362: @classmethod Line 363: def _persistentBackup(cls, filename): -- To view, visit http://gerrit.ovirt.org/8415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
