Dan Kenigsberg has submitted this change and it was merged. Change subject: Don't fail silently when ifup fails. ......................................................................
Don't fail silently when ifup fails. Up until now we discarded ifup return codes and ignored the possible errors present in ifup stdout. Use this information to perform better error reporting. The tests change is due to the fact that now that we treat ifup errors as excepcional occurences, for unit testing the persistent backups (thing which can be done by a regular user) we do not need to test ifup and ifdown of the current config as it is not a thing that the unprivileged user is normally allowed to do. Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a Signed-off-by: Antoni S. Puimedon <[email protected]> Bug-Url: https://bugzilla.redhat.com/856737 --- M tests/configNetworkTests.py M vdsm/configNetwork.py M vdsm/neterrors.py 3 files changed, 17 insertions(+), 3 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cc9dcc0a6b55d36fc937e1d364bd9c256ecd70a Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
