Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: storageMailboxTests: fix for f18 ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Does this affect other unit tests that might run in parallel? From the docs (http://docs.python.org/2/library/tempfile.html): Also, all the user-callable functions now take additional arguments which allow direct control over the location and name of temporary files. It is no longer necessary to use the global tempdir and template variables. To maintain backward compatibility, the argument order is somewhat odd; it is recommended to use keyword arguments for clarity. I'm not per se against it but I don't like changing those globals. .................................................... File tests/storageMailboxTests.py Line 36: def setUpModule(): Line 37: tempfile.tempdir = '/var/tmp/' Line 38: Line 39: Line 40: def teadDownModule(): I think you mean tearDownModule here. Line 41: tempfile.tempdir = _oldtempdir Line 42: Line 43: Line 44: class StoragePoolStub(object): -- To view, visit http://gerrit.ovirt.org/10225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2caacba292fc05118542ba3636281ef4970e32d4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
