Dan Kenigsberg has posted comments on this change.

Change subject: storageMailboxTests: fix for f18
......................................................................


Patch Set 1: (1 inline comment)

Ewoud, thanks!

Zhou, for some reason I thought that mkdtemp()'s dir is relative to tempdir.
Using it is indeed simpler.

....................................................
File tests/storageMailboxTests.py
Line 36: def setUpModule():
Line 37:     tempfile.tempdir = '/var/tmp/'
Line 38: 
Line 39: 
Line 40: def teadDownModule():
oops!
Line 41:     tempfile.tempdir = _oldtempdir
Line 42: 
Line 43: 
Line 44: class StoragePoolStub(object):


--
To view, visit http://gerrit.ovirt.org/10225
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2caacba292fc05118542ba3636281ef4970e32d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to