Vinzenz Feenstra has posted comments on this change. Change subject: Basic AMQP 1.0 transport support ......................................................................
Patch Set 13: Looks good to me, but someone else must approve (2 inline comments) I don't know proton, nor do I really know the library. However, I couldn't find any real culprits in the code which would look like an issue. Just two minorities with the unused variable and a typo in the comment. .................................................... File vdsm_api/jsonrpc/protonReactor.py Line 56: self.port = port Line 57: Line 58: self._isRunning = False Line 59: Line 60: self._hasData = threading.Event() Unused variable Line 61: Line 62: self._driver = proton.pn_driver() Line 63: Line 64: self._sessionContexts = [] Line 64: self._sessionContexts = [] Line 65: Line 66: def _convertTimeout(self, timeout): Line 67: """ Line 68: Timeouts in puthon are usually floats representing seconds, this puthon -> python Line 69: converts the conventional python timeout to proton compatible Line 70: millisecond timeouts Line 71: """ Line 72: -- To view, visit http://gerrit.ovirt.org/9987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I850005e7375472bbf6238fd38b10d8f1b5e2a191 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
