Vinzenz Feenstra has posted comments on this change.

Change subject: Basic AMQP 1.0 transport support
......................................................................


Patch Set 15: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm.spec.in
Line 489: /usr/sbin/usermod -a -G %{qemu_group},%{snlk_group} %{vdsm_user}
Line 490: /usr/sbin/usermod -a -G %{qemu_group},%{vdsm_group} %{snlk_user}
Line 491: 
Line 492: %post
Line 493: %{_bindir}/vdsm-tool sebool-config || :
Well whatever, I am just asking. I realized that it's not coming from you, it's 
just looking fishy.
However yes, this is supposed to suppress errors.
Line 494: # set the vdsm "secret" password for libvirt
Line 495: %{_bindir}/vdsm-tool set-saslpasswd
Line 496: 
Line 497: # Have moved vdsm section in /etc/sysctl.conf to /etc/sysctl.d/vdsm.


--
To view, visit http://gerrit.ovirt.org/9987
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I850005e7375472bbf6238fd38b10d8f1b5e2a191
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to