Shu Ming has posted comments on this change. Change subject: Do not fail when getVSize is called on an inctive LV. ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 3: AuthorDate: 2012-12-05 12:12:50 +0200 Line 4: Commit: Eduardo Warszawski <[email protected]> Line 5: CommitDate: 2012-12-05 12:12:50 +0200 Line 6: Line 7: Do not fail when getVSize is called on an inctive LV. s/inctive/inactive In my understanding, this patch address this situation: the engine is querying a LV by vdsm API on one host. And the LV in that host is inactive while it is can be active on other hosts. So the engine should query the right host instead of the one on which the LV is inactive. Because the LV is still active on some hosts, the size change may happen. But here we just give a quick solution to alleviate the log errors. On the other side, if the LV is inactive to all the hosts, we can expect no size change can happen. Then VDSM can return the cached size to engine instead of doing real read operation. Line 8: Line 9: Change-Id: I0a8b6da4d57cdf810769586c1959989d7a545d0c Line 10: Bug-uri: https://bugzilla.redhat.com/show_bug.cgi?id=878955 -- To view, visit http://gerrit.ovirt.org/9739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a8b6da4d57cdf810769586c1959989d7a545d0c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
