Yeela Kaplan has posted comments on this change. Change subject: Do not fail when getVSize is called on an inctive LV. ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm/storage/blockVolume.py Line 88: def refreshVolume(self): Line 89: lvm.refreshLV(self.sdUUID, self.volUUID) Line 90: Line 91: @classmethod Line 92: def getVSize(cls, sdobj, imgUUID, volUUID, bs=512): I would add a docstring describing the return value of the function(size of vol in blocks) Line 93: try: Line 94: size = _tellEnd(lvm.lvPath(sdobj.sdUUID, volUUID)) / bs Line 95: except IOError as e: Line 96: if e.errno == os.errno.ENOENT: -- To view, visit http://gerrit.ovirt.org/9739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a8b6da4d57cdf810769586c1959989d7a545d0c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Paikov <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
