Federico Simoncelli has posted comments on this change. Change subject: Rename lease files on v3 file SDs when renaming data and meta files ......................................................................
Patch Set 1: No score (1 inline comment) .................................................... File vdsm/storage/fileVolume.py Line 505: vars.task.pushRecovery(task.Recovery(name, "fileVolume", Line 506: "FileVolume", Line 507: "renameVolumeRollback", Line 508: [metaPath, prevMetaPath])) Line 509: self.oop.os.rename(prevMetaPath, metaPath) Don't we need a rollback for the lease file too? Line 510: try: Line 511: self.oop.os.rename(prevLeasePath, leasePath) Line 512: except OSError, e: Line 513: if e.errno != os.errno.ENOENT: -- To view, visit http://gerrit.ovirt.org/10208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3b3a2cf3499cc50b35b384ca72624d7f71c041a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
