Dan Kenigsberg has posted comments on this change. Change subject: Rename lease files on v3 file SDs when renaming data and meta files ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/fileVolume.py Line 514: "renameVolumeRollback", Line 515: [leasePath, prevLeasePath])) Line 516: try: Line 517: self.oop.os.rename(prevLeasePath, leasePath) Line 518: except OSError, e: I find it odd that you do not even log the ENOENT case, but let's trust you and your reviewers. Line 519: if e.errno != os.errno.ENOENT: Line 520: raise Line 521: self.volUUID = newUUID Line 522: self.volumePath = volPath -- To view, visit http://gerrit.ovirt.org/10208 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3b3a2cf3499cc50b35b384ca72624d7f71c041a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
