Pradipta Banerjee has posted comments on this change.
Change subject: Adding getBiosInfo API to vdsm cli and merge bios information
with vdsGetCaps
......................................................................
Patch Set 16: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/API.py
Line 1131: def getBiosInfo(self):
Line 1132: """
Line 1133: Report host bios information
Line 1134: """
Line 1135: bios = supervdsm.getProxy().getDmidecodeInfo()
What about renaming the getDmidecodeInfo method to getPlatformBiosInfo() or
getHardwareInfo() as suggested by Alon? Appears more generic.
Line 1136: return {'status': doneCode, 'info': bios}
Line 1137:
Line 1138: def getStats(self):
Line 1139: """
....................................................
File vdsm/supervdsmServer.py
Line 95: # This method exists for testing purposes
Line 96: return True
Line 97:
Line 98: @logDecorator
Line 99: def getDmidecodeInfo(self, *args, **kwargs):
A generic method name like getHardwareInfo, as suggested by Alon or
getPlatformBiosInfo is much better..
Line 100: if machine() in ('x86_64', 'i686'):
Line 101: from dmidecodeUtil import getSystemStructure as
_getSystemStructure
Line 102: return _getSystemStructure()
Line 103: else:
--
To view, visit http://gerrit.ovirt.org/9258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic429ef101fcf9047c4b552405314dc7ba9ba07a0
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Andrew Cathrow <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
