Federico Simoncelli has posted comments on this change. Change subject: netinfo: remove special characters from DUMMY_BRIDGE ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/netinfo.py Line 42: NET_CONF_PREF = NET_CONF_DIR + 'ifcfg-' Line 43: PROC_NET_VLAN = '/proc/net/vlan/' Line 44: Line 45: LIBVIRT_NET_PREFIX = 'vdsm-' Line 46: DUMMY_BRIDGE = 'vdsmdummy' Briefly looking at all the places where DUMMY_BRIDGE is used I didn't find any place where the semicolons are required. Please correct me if I'm wrong and I'll revise the patch. Line 47: Line 48: Line 49: def _match_nic_name(nic, patterns): Line 50: return any(map(lambda p: fnmatch(nic, p), patterns)) -- To view, visit http://gerrit.ovirt.org/10653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5a03a1f88495731bc107d5301fab43354f4e36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
