Federico Simoncelli has posted comments on this change. Change subject: netinfo: remove special characters from DUMMY_BRIDGE ......................................................................
Patch Set 1: There are many solutions to avoid name collisions (for example I would personally like to prefix names coming from the ovirt engine with "ovirt-"). Choosing special characters looks like a risky one. Basically the gui/engine sanitizes the user input to avoid problems but then vdsm creates bridges with the same special characters that were prohibited? Moreover this is not an explicit policy to avoid collisions (it required to be explained) and it might be forgotten in the future. Anyway I had a real specific issue using puppet: sh: -c: line 0: syntax error near unexpected token `|' sh: -c: line 0: `arp -en -i ;vdsmdummy; | sed -e 1d' I bet there will be other hidden ones in all the system scripts dealing with interfaces. BTW do you prohibit also other names on the engine side? What about virbr0? If you do you could also prohibit vdsmdummy (and what about "vdsmdummy0", just to be more consistent with the network interface naming). -- To view, visit http://gerrit.ovirt.org/10653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5a03a1f88495731bc107d5301fab43354f4e36 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
