Antoni Segura Puimedon has posted comments on this change.
Change subject: pep8 fix of contrib vds_bootstrap and vdsm_reg.
......................................................................
Patch Set 1:
Output of gitpydiff:
antoni@nx01 ~/code/vdsm> gitpydiff
checking contrib/nfs-check.py
2 difference(s)
first file: contrib/nfs-check.py
second file: /tmp/pydiff/contrib/nfs-check.py
((90, "Compare(Name('localMachine'), [('==', Name('True'))])"),
(95, "Name('localMachine')"))
((111, "Compare(Name('targetFound'), [('==', Name('False'))])"),
(116, "Name('targetFound')"))
checking vds_bootstrap/vds_bootstrap.py
1 difference(s)
first file: vds_bootstrap/vds_bootstrap.py
second file: /tmp/pydiff/vds_bootstrap/vds_bootstrap.py
((820, '=='), (862, 'is'))
checking vds_bootstrap/vds_bootstrap_complete.py
checking vdsm_reg/config.py.in
checking vdsm_reg/deployUtil.py.in
15 difference(s)
first file: vdsm_reg/deployUtil.py.in
second file: /tmp/pydiff/vdsm_reg/deployUtil.py.in
((584,
"Compare(CallFunc(Name('type'), [Name('srvName')], None, None), [('==',
CallFunc(Name('type'), [Name('None')], None, None))])"),
(624,
"CallFunc(Name('isinstance'), [Name('srvName'), Name('None')], None, None)"))
((624, "Name('Exception')"),
(665,
'CallFunc(Name(\'Exception\'), [Const("The \'reset\' action is not yet
implemented for systemd")], None, None)'))
((625, Const("The 'reset' action is not yet implemented for systemd")),
(665, None))
((668, '!='), (712, 'is not'))
((1381, Discard(Const(None))), ('1484 + -', None))
((1442, Discard(Const(None))), ('1549 + -', None))
((1445, Discard(Const(None))), ('1552 + -', None))
((1445, Discard(Const(None))), ('1552 + -', None))
((1449, Discard(Const(None))), ('1556 + -', None))
((1449, Discard(Const(None))), ('1556 + -', None))
((1500, '=='), (1608, 'is'))
((1502, '!='), (1610, 'is not'))
((1504, '!='), (1612, 'is not'))
((1515, '!='), (1624, 'is not'))
((1647,
'\n The fingerprint to compare to the fingerprint of the
downloaded\n certificate'),
(1762,
'The fingerprint to compare to the fingerprint of the downloaded
certificate'))
checking vdsm_reg/engine.py.in
2 difference(s)
first file: vdsm_reg/engine.py.in
second file: /tmp/pydiff/vdsm_reg/engine.py.in
((70,
Discard(Const("\nUntil the version 3.0, oVirt Engine provided port 8443/8080
to oVirt Node\ndownload cert and others files. Since 3.1 the default port
changed to 443/80.\nThis function, will return the compatible port in case the
VDSM\ncannot communicate with oVirt Engine.\n\n:param portNumber: port which
doesn't communicate with oVirt Engine\n:returns: compatible port number (or
None if there is no compatible port)\n and if it's SSL port or not
(bool)\n"))),
('64 + -', None))
((92,
Discard(Const("\nThis function will try a http connection to a host with
determined\nport, ssl and timeout.\n\n:param host: Host to be tested\n:param
port: Which port httplib should use for the test connection\n:param ssl: if
it's ssl port or not (bool)\n:param timeout: timeout for the operation, if not
speficied the default\n will be
socket._GLOBAL_DEFAULT_TIMEOUT\n:returns True or False\n"))),
('86 + -', None))
checking vdsm_reg/register-to-engine.py
antoni@nx01 ~/code/vdsm>
--
To view, visit http://gerrit.ovirt.org/10771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b1bc34c65fc67a04c11ba7d7c49d57f3cc4811
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
