Zhou Zheng Sheng has posted comments on this change.
Change subject: pep8 fix of contrib vds_bootstrap and vdsm_reg.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_reg/deployUtil.py.in
Line 620:
Line 621: nReturn = 0
Line 622: out = None
Line 623: err = None
Line 624: if isinstance(srvName, None):
This would explode. It should be
import types
if isinstance(srvName types.NoneType):
but in fact we can just write
if srvName is None:
Line 625: nReturn = 1
Line 626: message = "setService: ignoring None service."
Line 627: err = message
Line 628: logging.error(message)
Line 1482:
Line 1483: msr = _prdmsr(0, MSR_IA32_FEATURE_CONTROL)
Line 1484: return (msr & (MSR_IA32_FEATURE_CONTROL_LOCKED |
Line 1485: MSR_IA32_FEATURE_CONTROL_VMXON_ENABLED)) != \
Line 1486: MSR_IA32_FEATURE_CONTROL_LOCKED
I think it should be
return (msr & (MSR_IA32_FEATURE_CONTROL_LOCKED |
MSR_IA32_FEATURE_CONTROL_VMXON_ENABLED)) != \
MSR_IA32_FEATURE_CONTROL_LOCKED
I mean MSR_IA32_FEATURE_CONTROL_VMXON_ENABLED should align with
MSR_IA32_FEATURE_CONTROL_LOCKED in the upper line, since they a in the same
level.
Line 1487:
Line 1488:
Line 1489: def _cpu_has_svm_support():
Line 1490: SVM_CPUID_FEATURE_SHIFT = 2
--
To view, visit http://gerrit.ovirt.org/10771
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b1bc34c65fc67a04c11ba7d7c49d57f3cc4811
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
