Antoni Segura Puimedon has posted comments on this change.

Change subject: split restore-net-conf away of vdsmd.init service
......................................................................


Patch Set 1: (2 inline comments)

It looks mostly ok. But there were a couple of typos.

....................................................
File vdsm.spec.in
Line 510: 
Line 511: %if 0%{?rhel}
Line 512: if [ "$1" -eq 1 ] ; then
Line 513:     /sbin/chkconfig --add vdsmd
Line 514:     /sbin/chkconfig --add vdsm-resotre-net-config
typo s/vdsm-resotre/vdsm-restore/
Line 515: fi
Line 516: %else
Line 517: if [ "$1" -eq 1 ] ; then
Line 518:     /bin/systemctl enable vdsmd.service >/dev/null 2>&1 || :


Line 527: if [ "$1" -eq 0 ]
Line 528: then
Line 529:     /sbin/service vdsmd stop > /dev/null 2>&1 || :
Line 530:     /sbin/chkconfig --del vdsmd
Line 531:     /sbin/chkconfig --del vdsm-resotre-net-config
typo s/vdsm-resotre/vdsm-restore/
Line 532: 
Line 533:     /bin/sed -i '/# by vdsm$/d' \
Line 534:         /etc/libvirt/libvirtd.conf \
Line 535:         /etc/libvirt/qemu.conf \


--
To view, visit http://gerrit.ovirt.org/10334
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe00320d090b9055c3d619260ed57ee953702f1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to