Antoni Segura Puimedon has posted comments on this change. Change subject: split restore-net-conf away of vdsmd.init service ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/vdsm-restore-net-config.service Line 1: [Unit] Line 2: Description=Restore failed Vdsm network configuration on boot Line 3: Requires=libvirtd.service That is a good point. This would prevent the admin from disabling the restore while keeping vdsmd. Certainly this would result in a stronger enforcement of the intended way to have the two services work. Line 4: Before=vdsmd.service Line 5: Line 6: [Service] Line 7: Type=oneshot -- To view, visit http://gerrit.ovirt.org/10334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabe00320d090b9055c3d619260ed57ee953702f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
