Antoni Segura Puimedon has posted comments on this change.
Change subject: watchdog hook
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File vdsm_hooks/watchdog/before_vm_start.py
Line 36:
Line 37: hooking.write_domxml(domxml)
Line 38:
Line 39: except:
Line 40: sys.stderr.write('watchdog: [unexpected error]: %s\n' %
traceback.format_exc())
This should be split in two lines not to go over 80 chars.
sys.stderr.write('watchdog: [unexpected error]: %s\n' %
traceback.format_exc())
Line 37: hooking.write_domxml(domxml)
Line 38:
Line 39: except:
Line 40: sys.stderr.write('watchdog: [unexpected error]: %s\n' %
traceback.format_exc())
Line 41:
The blank line at the end of line should be removed.
--
To view, visit http://gerrit.ovirt.org/10619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1d21ff8e14013869d78532632e8485f0414793
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
