Laszlo Hornyak has posted comments on this change. Change subject: WIP watchdog hook ......................................................................
Patch Set 7: (1 inline comment) .................................................... File vdsm_hooks/watchdog/before_vm_start.py Line 35: devices.appendChild(watchdog_device) Line 36: Line 37: hooking.write_domxml(domxml) Line 38: Line 39: except: I would expect IndexError if the device:action format is broken, or if no devices element found (if this is possible at all) If we add all the exceptions we can think of, it will not catch the ones we did not think of and in such cases the error will be harder to find in the logs Line 40: sys.stderr.write( -- To view, visit http://gerrit.ovirt.org/10619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc1d21ff8e14013869d78532632e8485f0414793 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
